Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve version range resolution #183

Merged
merged 8 commits into from
Sep 12, 2023
Merged

Improve version range resolution #183

merged 8 commits into from
Sep 12, 2023

Conversation

keshav-space
Copy link
Member

@keshav-space keshav-space commented Sep 6, 2023 •
edited
Loading

  • Handle invalid constraints sequence exception while testing whether a given version is present in given vers expression
  • Handle potential invalid version string
  • Skip vers resolution for unsupported ecosystems, currently on_demand_queue only supports maven and npm
  • Bump univers to v30.10.1

JonoYang
JonoYang requested changes Sep 7, 2023
View reviewed changes
Copy link
Member

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keshav-space I have some questions about the try-except blocks you've added.

packagedb/api.py Outdated Show resolved Hide resolved
packagedb/api.py Outdated Show resolved Hide resolved
packagedb/api.py Outdated Show resolved Hide resolved
packagedb/api.py Outdated Show resolved Hide resolved
packagedb/api.py Outdated Show resolved Hide resolved
packagedb/api.py Show resolved Hide resolved
@keshav-space
Add logging for exceptions
a126277 
Signed-off-by: Keshav Priyadarshi <[email protected]>
keshav-space and others added 3 commits September 12, 2023 14:49
@keshav-space
Bump univers to v30.11.0
f03ad38 
Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space
Handle InvalidConstraintsError exception
ea27db4 
Signed-off-by: Keshav Priyadarshi <[email protected]>
@JonoYang
Update test expectation
b7d323b 
Signed-off-by: Jono Yang <[email protected]>
@JonoYang
Copy link
Member

@keshav-space Thanks for the univers update! I've regenerated a test file, so we can pass all the tests. Merging.

@JonoYang JonoYang merged commit 8428cb8 into main Sep 12, 2023
8 checks passed
@keshav-space keshav-space deleted the improve-vers-resolution branch September 12, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne Awaiting requested review from pombredanne

@JonoYang JonoYang Awaiting requested review from JonoYang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keshav-space @JonoYang @pombredanne